Am 10/26/2012 10:23 AM, schrieb Nick Sabalausky:

On Fri, 26 Oct 2012 09:40:15 +0200
Sönke Ludwig wrote:

Merged in.


btw, my fingers are itching everytime I see that connection.d file. I
would really like to rip apart this huge mess and restructure

  • I hate those gigantic spaghetti modules. But then again I'd rather
    leave it like this to keep it compatible with the other forks..

The simendsjo fork is the only other one I'm aware of (other than Steve
Teale's original, but I think it's safe to assume Teale's not likely to
continue it since nobody's heard from him in a year). And, though I hate
to put words in anyone's mouth, simendsjo doesn't seem particularly
interested anymore: IIRC, he's said he's not using MySQL anymore, and
his last commit was a few months ago.

So unless there's other active forks I don't know about, I think this
might actually be a perfect time for restructuring, especially since the
vibe.d fork has just been synched up with simendsjo's.

I thought I had seen another one, but I will check again and put it on
the todo list if not.

Speaking of restructuring, I just noticed that there's another mysql
connection pool class inside connection.d. Probably one of simendsjo's
additions. We should probably look at that, pull anything good out into
the class in 'mysql/db.d', and then remove the one in connection.d.

Ah right, I've seen that during merging and the forgot about it...

Also on the same topic, do you think the Connection class in mysql/db.d
should maybe be renamed to something like "MySqlConnectionPool"?
"Connection" seems misleadingly generic, as if it's a parent interface
to TcpConnection and UdpConnection.

Yes, and it would also be in line with the MongoDb and Redis classes.