On Wed, 19 Mar 2014 11:13:05 GMT, Sönke Ludwig wrote:
On Wed, 19 Mar 2014 11:06:37 GMT, Anton Gushcha wrote:
On Wed, 19 Mar 2014 10:58:04 GMT, Sönke Ludwig wrote:
I am going to start work on pull request for this issue. As i see the main pitfall is requirement to track for virtual hosts, that uses the same interface. Should
HTTPListener.stopListeningthrow an exception at that case of just do nothing?I'd say that for simplicity
HTTPListenershould contain thesettingsobject and therequest_delegate. It would then remove allHTTPServerContexts with those values and then clean up anyHTTPServerListeners that don't have any associated contexts anymore.To keep this unambiguous,
listenHTTPPlainwould throw an exception if someone tries to use the samesettings/request_handlercombination to listen twice.
Ok, it is clear for me (excepting "that don't have any associated contexts anymore", but i still need to read all corresponding code attentively). By the way, listenHTTPPlain is private in ~master branch, but docs is still refers to as valid user API.